Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Remove HStack #4749

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Dashboard] Remove HStack #4749

merged 1 commit into from
Sep 23, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 22, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces changes to replace HStack with div and flex flex-row classes in multiple components for better flexibility and styling.

Detailed summary

  • Replaced HStack with div and flex flex-row in various components for styling improvements.

The following files were skipped due to too many changes: apps/dashboard/src/components/smart-wallets/SponsorshipPolicies/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3eef910

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 22, 2024 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 22, 2024 17:54 Inactive
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel Vercel
Copy link

vercel bot commented Sep 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 1:41am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 23, 2024 1:41am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 23, 2024 1:41am
wallet-ui ⬜️ Skipped (Inspect) Sep 23, 2024 1:41am

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 22, 2024 17:54 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 22, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Sep 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo changed the title Update [Dashboard] Remove HStack Sep 22, 2024
@kien-ngo kien-ngo mentioned this pull request Sep 22, 2024
Merged
@kien-ngo kien-ngo marked this pull request as ready for review September 22, 2024 17:54
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.06%. Comparing base (3d52dd4) to head (3eef910).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4749   +/-   ##
=======================================
  Coverage   49.06%   49.06%           
=======================================
  Files        1054     1054           
  Lines       56856    56856           
  Branches     3890     3890           
=======================================
  Hits        27899    27899           
  Misses      28324    28324           
  Partials      633      633
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3d52dd4
packages 45.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 22, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.73 KB (0%) 875 ms (0%) 411 ms (+104.85% 🔺) 1.3 s
thirdweb (cjs) 100.91 KB (0%) 2.1 s (0%) 751 ms (+11.98% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 86 ms (+257.82% 🔺) 182 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 66 ms (+977.64% 🔺) 76 ms
thirdweb/react (minimal + tree-shaking) 16.73 KB (0%) 335 ms (0%) 132 ms (+182.08% 🔺) 466 ms

@kien-ngo kien-ngo mentioned this pull request Sep 22, 2024
Merged
jnsdls
jnsdls approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jnsdls jnsdls added the merge-queue Adds the pull request to Graphite's merge queue. label Sep 23, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 23, 2024 •
edited
Loading

Merge activity

  • Sep 22, 9:29 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 22, 9:29 PM EDT: jnsdls added this pull request to the Graphite merge queue.
  • Sep 22, 9:41 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

@kien-ngo
[Dashboard] Remove HStack (#4749)
3eef910 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces changes to replace `HStack` with `div` using flex classes in various components for better styling consistency.

### Detailed summary
- Replaced `HStack` with `div` using flex classes in multiple components for styling consistency.

> The following files were skipped due to too many changes: `apps/dashboard/src/components/smart-wallets/SponsorshipPolicies/index.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Base automatically changed from kien/remove-vstack-2 to main September 23, 2024 01:40
@graphite-app graphite-app bot merged commit 3eef910 into main Sep 23, 2024
29 checks passed
@graphite-app graphite-app bot deleted the kien/remove-hstack branch September 23, 2024 01:41
@vercel vercel bot temporarily deployed to Production – wallet-ui September 23, 2024 01:41 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 23, 2024 01:41 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 23, 2024 01:41 Inactive
This was referenced Sep 23, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsdls jnsdls jnsdls approved these changes

@MananTank MananTank Awaiting requested review from MananTank MananTank is a code owner

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges joaquim-verges is a code owner

Assignees
No one assigned
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kien-ngo @jnsdls